code quality: making all the pixel based renderers `final`

as they are only a thin wrapper of `stbi` functions

src/QR.cpp

@@ -12,16 +12,8 @@
 
 namespace massivedynamic {
 
-QR::QR(const std::string& data, std::string outputFile, size_t size, qrcodegen::QrCode::Ecc type) : outputFile(std::move(outputFile)) {
+QR::QR(const std::string& data, std::string outputFile, size_t size, qrcodegen::QrCode::Ecc type) : outputFile(std::move(outputFile)), 
-	qrcodegen::QrCode qr = qrcodegen::QrCode::encodeText(data.c_str(), type);
+		qr(qrcodegen::QrCode::encodeText(data.c_str(), type)), size(size) {
-	
-	static_assert(FormatLength == 5, "exhaustive formats: did you miss to add something here?");
-	this->renderers.insert({Format::CONSOLE, std::make_unique<ConsoleRenderer>(this->pixels, qr.getSize(), size)});
-	this->renderers.insert({Format::PNG,     std::make_unique<PNGRenderer>(this->pixels, qr.getSize(), size)});
-	this->renderers.insert({Format::SVG,     std::make_unique<SVGRenderer>(this->pixels, qr.getSize(), size)});
-	this->renderers.insert({Format::JPG,     std::make_unique<JPGRenderer>(this->pixels, qr.getSize(), size)});
-	this->renderers.insert({Format::BMP,     std::make_unique<BMPRenderer>(this->pixels, qr.getSize(), size)});
-
 	// this is inherently stupid, but "qrcodegen::QrCode" does not give access to the
 	// `segments` vector member and the class itself is marked final.
 	for (int y = 0; y < qr.getSize(); y++) {
@@ -32,9 +24,15 @@ QR::QR(const std::string& data, std::string outputFile, size_t size, qrcodegen::
 }
 
 void QR::render(Format format) {
-	assert(this->renderers.find(format) != this->renderers.end() && "ERROR: a non-valid renderer has been selected");
+	static_assert(FormatLength == 5, "exhaustive formats: did you miss to add something here?");
-
+	switch(format) {
-	this->renderers.at(format)->render(this->outputFile);
+		case Format::CONSOLE : this->renderTyped<ConsoleRenderer>(); break;
+		case Format::PNG     : this->renderTyped<PNGRenderer>(); break;
+		case Format::SVG     : this->renderTyped<SVGRenderer>(); break;
+		case Format::JPG     : this->renderTyped<JPGRenderer>(); break;
+		case Format::BMP     : this->renderTyped<BMPRenderer>(); break;
+		case Format::END     : break;
+	}
 }
 
 }

src/QR.hpp

@@ -2,8 +2,6 @@
 
 #include <vector>
 #include <string>
-#include <memory>
-#include <unordered_map>
 
 #include "qrcodegen.hpp"
 #include "Renderer.hpp"
@@ -25,7 +23,8 @@ namespace massivedynamic {
 		private:
 			std::string outputFile;
 			std::vector<bool> pixels;
-			std::unordered_map<Format, std::unique_ptr<Renderer>> renderers;
+			qrcodegen::QrCode qr;
+			size_t size;
 		public:
 			QR(const std::string& data, std::string outputFile, size_t size, qrcodegen::QrCode::Ecc type);
 			QR(const QR&&)  = delete;
@@ -33,6 +32,12 @@ namespace massivedynamic {
 			~QR()           = default;
 
 			void render(Format format);
+
+			template<typename T>
+			void renderTyped() {
+				T renderer = T(this->pixels, this->qr.getSize(), this->size);
+				renderer.render(this->outputFile);
+			}
 	};
 
 }

src/renderers/BMPRenderer.hpp

@@ -6,7 +6,7 @@
 
 namespace massivedynamic {
 
-class BMPRenderer : public PixelRenderer {
+class BMPRenderer final : public PixelRenderer {
 	public:
 		BMPRenderer(const std::vector<bool>& pixels, size_t sourceSize, size_t targetSize) : PixelRenderer(pixels, sourceSize, targetSize) {}
 

src/renderers/JPGRenderer.hpp

@@ -6,7 +6,7 @@
 
 namespace massivedynamic {
 
-class JPGRenderer : public PixelRenderer {
+class JPGRenderer final: public PixelRenderer {
 	public:
 		JPGRenderer(const std::vector<bool>& pixels, size_t sourceSize, size_t targetSize) : PixelRenderer(pixels, sourceSize, targetSize) {}
 

src/renderers/PNGRenderer.hpp

@@ -6,7 +6,7 @@
 
 namespace massivedynamic {
 
-class PNGRenderer : public PixelRenderer {
+class PNGRenderer final: public PixelRenderer {
 	public:
 		PNGRenderer(const std::vector<bool>& pixels, size_t sourceSize, size_t targetSize) : PixelRenderer(pixels, sourceSize, targetSize) {}