Make the Editor.js link input readable in dark mode (#52) #58
No reviewers
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
MassiveDynamic/kataba!58
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "feature/52-link-ui-dark-mode"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Closes #52
Editor.js hard-codes a light background (
#F8F8F8) on the inline link tool's URL field (.ce-inline-tool-input), so in dark mode the text was white on near-white. The field now uses the theme's surface, border, text and placeholder tokens (ADR-0010). The class is doubled, as on the.ce-popoveroverride, because Editor.js adds its styles after ours. The rule covers every Editor.js instance: guide and category descriptions and step content.Test
New e2e test in
e2e/richText.spec.ts. It opens the link tool in dark mode and asserts a WCAG contrast of at least 4.5, usingcontrastRatiofromsrc/theme/colour.ts. It fails without the fix (1.05) and passes with it.🤖 Generated with Claude Code