A favicon.ico beside the SVG icon #157
Labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
MassiveDynamic/kataba#157
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Problem
kataba's only favicon is
src/app/icon.svg(plusapple-iconfor iOS)./favicon.icoanswers 404, as the not-found page.Browsers and services that don't use the SVG icon, or only ever ask for
/favicon.ico, show no icon for kataba: feed readers, bookmark sync, link previews, some browsers. In Vivaldi the tab of a local instance showed no icon while Safari showed it, though both got the same<link rel="icon">(which may also be Vivaldi's favicon cache).Wanted
src/app/favicon.iconext toicon.svg, so Next serves/favicon.icoand links it in<head>, with the same mark as the SVG at 16, 32 and 48 px.prefers-color-scheme, so it needs one look that is readable on light and dark tab strips (e.g. the dark mark on a light rounded square, or the brand colour).favicon.icofromRESERVED_PAGE_SLUGSintoAPP_ROUTE_NAMES(src/contentPages/slug.ts): otherwise the guest 404 proxy (hiddenFromGuest) takes it for a page slug and answers guests with the not-found page, as it does now. Then check that/favicon.icoanswers 200 withimage/x-iconfor guests, on the dev server and in the Docker image.